Hi Ayushman, On Mon 2024-01-29 18:09:40 +0530, Ayushman Tripathi wrote: > Hello Yuchen,
> I'm sending this (exact) same email again because my last email was > rejected by the list moderator, and the following reason was emailed > to me: > "I'm rejecting your message, it's too long for a mailing list; please > consider publishing the long part somewhere else and posting a link -- > ineiev" > This time I tried to include attachments (earlier, 565 KB) as a link. Sorry about the problem. Yes sometimes this happens. > On 27-01-2024 06:34, Yuchen Pei wrote: > Here are a few things that came to my mind: > - Use an update-to-date acorn library. Currently it is pinned to > version <=8.7.1. First step: remove this constraint and see what > happens. > I installed acorn with its latest version (^8.11.3), and then I built > the extension and created a .xpi package. > I installed the generated librejs.xpi in Firefox Developer Edition. > And it's working well without any issues. I've attached the generated > bundle.js file and package.json. > bundle.js file URL (I cannot directly upload it as my last email to > the mailing list was rejected by the list moderator due to this > reason): https://usercontent.irccloud-cdn.com/file/4xH6fuBn/bundle.js > librejs.xpi file URL: > https://usercontent.irccloud-cdn.com/file/HQ7f9Ynl/librejs.xpi > librejs.xpi working Screenshot URL: > https://usercontent.irccloud-cdn.com/file/GDwAgBCd/lp6kxT6SrXh7BmTk.png Thanks for checking this. You are right. I checked why I placed the version restriction <=8.7.1, and it seemed to be failing unit tests when using 8.8.0. These tests no longer fail now with 8.11.3. I have thus pushed a commit updating the readme and the manual: a468d1091a956a2c6ad86185fbd3006fb044d7c3. If you want to see that 8.8.0 causes test failure, please refer to README for how to build and run tests. > * Best, Yuchen -- Dr Yuchen Pei | https://ypei.org | Timezone: UTC+11 PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0 https://ypei.org/assets/ypei-pubkey.txt
