On Fri, Mar 8, 2019 at 5:30 PM Jeffrey Walton <noloa...@gmail.com> wrote:
Thanks for the UBSAN testing and report, and to Bruno for all the fixes. > On Fri, Mar 8, 2019 at 6:36 PM Bruno Haible <br...@clisp.org> wrote: > > ... > > I'm pushing the attached patches. > > Thanks Bruno, got them. 0.9.10 tested good with them. > > (I should be starting on -fsanitize=address this weekend. Address > Sanitizer is a little trickier because I've seen findings that I could > not explain or repro with Valgrind). For some types of problems, that is expected: valgrind detects few things (UMR is the one I miss the most. use MSAN for those if you can manage to instrument all dependent libraries) that ASAN does not catch. However, ASAN catches many types of bugs that valgrind cannot detect.