> Marc had proposed a patch, that doesn't seem to have been
> applied.
>
> http://codereview.appspot.com/181144
> http://lists.gnu.org/archive/html/lilypond-devel/2010-01/msg00162.html
>
> Can anyone have a look?
I can't comment on the C++ code, and I haven't studied the
output-lib.scm stuff, but...
1) the symbol has one too many squiggles, if we're using
this as our model:
http://code.google.com/p/lilypond/issues/detail?id=659
2) to separate paragraphs in the bar-line interface
docstring, you need to use "\n\n" --- one "\n" doesn't
generate a paragraph break. Also, don't start new
paragraphs with spaces. You can use the attached patch
to fix this.
3) again in the bar-line interface docstring, if @code{...}
isn't inside its own set of parentheses "(@code{...})",
@samp{...} is better. However, glancing around I see
that none of the other docstrings do this, so maybe
that should be addressed separately.
4) do you need to make a regression test?
5) you should also mention this in changes.tely
Other than that, this looks like some great work. Thanks
for contributing!
- Mark
ps. it's fun to see my auto-categorizing code in action
(in font-table.ly)
diff --git a/lily/bar-line.cc b/lily/bar-line.cc
index dcc7da2..d3f21e5 100644
--- a/lily/bar-line.cc
+++ b/lily/bar-line.cc
@@ -428,19 +428,22 @@ ADD_INTERFACE (Bar_line,
" a thin-thick double repeat, a thick bar, a double bar, a start bar,"
" an end bar, a thick double bar, a thin-thick-thin bar,"
" a dotted bar, a dashed bar, a tick as bar line and a segno bar.\n"
- " In addition, there is an option"
+ "\n"
+ "In addition, there is an option"
" @code{||:} which is equivalent to @code{|:} except at line"
" breaks, where it produces a double bar (@code{||}) at the"
" end of the line and a repeat sign (@code{|:}) at the"
" beginning of the new line.\n"
- " For segno, @code{S} produces a segno sign except at line breaks,"
+ "\n"
+ "For segno, @code{S} produces a segno sign except at line breaks,"
" where it produces a double bar (@code{||}) at the"
" end of the line and a segno sign at the beginning of the new line."
" @code{|S} is equivalent to @code{S} but produces a simple bar line"
" (@code{|}) instead of a double bar line (@code{||}) at line breaks."
" @code{S|} produces the segno sign at line breaks and starts the following"
" line without special bar lines.\n"
- " @code{S|:} and @code{:|S} are used for repeat/segno combinations that are"
+ "\n"
+ "@code{S|:} and @code{:|S} are used for repeat/segno combinations that are"
" separated at line breaks. Alternatively, @code{.S|:} and @code{:|S.}"
" may be used which combine repeat signs and segno at the same line in"
" case of a line break. @code{:|S|:} is a combination of a left repeat"
_______________________________________________
bug-lilypond mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
