On 8/28/10 9:11 AM, "Neil Puttock" <[email protected]> wrote:
> On 28 August 2010 14:46, Marc Hohl <[email protected]> wrote:
>
>> Just a little ping - is the patch ok, or should I load it to Rietveld?
>
> Looks OK apart from this:
>
> + %% NOTE: in lily/stem-tremolo.cc, we have length-fraction = 1,
> + %% and the tablature staff space is scaled by 1.5, so we use 1/1.5=0.67
>
> These comments should be above the \override, and will be incorrect if
> a user decides to change staff-space (though it's debatable whether
> it's worth complicating all the overrides to account for staff-space
> changes).
Why not use 1/staff-space? This would adjust things regardless of how
staff-space was tweaked, wouldn't it?
Carl
_______________________________________________
bug-lilypond mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-lilypond
