Comment #6 on issue 2230 by [email protected]: add svg regtests
http://code.google.com/p/lilypond/issues/detail?id=2230

I set Patch=needs_work as soon as I noticed the problem... looks like it wasn't early enough.

The interesting bit comes a bit earlier in the log:
No files specified. Doing nothing

This comes from lys-to-tely script, and indeed there are no files specified because there are no regression tests added yet in the input/regresssion/svg directory.

Now, how could I have missed that? I have a dummy .ly file in my tree under input/regression/svg, so everything progresses perfectly. I didn't add this .ly file to the patch because it is a rather silly little file that doesn't test anything specific. When I remove the file, make check still passes, because the file out-test/collated-files.tely is present from the previous run. So I didn't expect that an empty regtest dir would cause problem. The only way for me to have noticed the problem would be to start from a new build dir, but that's what I expect patchy to do. So I upload the patch and overnight I ran patchy.

(PS. the trailing whitespace warning comes from git patch --reverse)


_______________________________________________
bug-lilypond mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-lilypond

Reply via email to