Hi
I have a few questions about the section "Patch label" in:
http://lilypond.org/doc/v2.19/Documentation/contributor/issue-classification
Patch-new: the patch has not been checked for “obvious” mistakes.
When in doubt, use this tag.
Patch-review: the patch has no “obvious” mistakes (as checked by
the Patch Meister), and is ready for review from main developers.
Developers with git push ability can use this category, skipping over
patch-new.
Recently I've followed this guide and used Patch-review immediately
after uploading the patch, because I thought this would have saved
manual work to James.
But I've just learned from Phil that if I skip immediately to
Patch-review the tests won't run¹. This is confirmed by this chapter:
http://lilypond.org/doc/v2.19/Documentation/contributor/the-patch-review-cycle
I can't remember if Patchy still does (after the move to
Allura/Sourceforge) what's described there.
Anyway, I would add a link to the-patch-review-cycle from
issue-classification#patch-label section and I would change the above
paragraph to say that automatic tests are run when an issue is set to
Patch-new.
¹ https://sourceforge.net/p/testlilyissues/issues/4857/
_______________________________________________
bug-lilypond mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/bug-lilypond
