On 9/30/17 4:46 PM, "David Kastrup" <[email protected]> wrote: >Karlin High <[email protected]> writes: > >> This is a nitpick. The places in the documentation that reference the >> "Harmonia Sacra" songbook by Joseph Funk have the spelling Harmonica >> Sacra. Harmonia does not have a "c" here. A few references are below. >> There are enough of them that a Google search for "Joseph Funk >> Harmonica Sacra" gets auto-corrected. >> >> http://harmoniasacra.org/index.html >> http://gameo.org/index.php?title=Harmonia_Sacra >> https://www.amazon.com/Harmonia-Sacra-Joseph-Funk/dp/1932676155 >> >> The attached patch has proposed corrections. Translated docs would be >> affected; I do not know the process for that. Possible actions: >> >> * Forget it. Anyone who would be bothered by this is probably beyond >>help. >> * Fix directly in git like other typos >> * Go through review and tracker like other patches > >I'd use option 2 here (of course, push to staging rather than master) >after carefully reading the diff and making sure that no chapter/node >names are affected (which would constitute a structural change and thus >should be checked doing "make doc" before possibly inconveniencing >others by a broken staging, either by checking yourself or creating an >issue after all). > >We have had a fair share of "this could not possibly break compilation" >kind of changes breaking compilation. > >Also any possibility for contention is worth a review. This here seems >solid enough to me.
I agree with David. Thanks, Carl _______________________________________________ bug-lilypond mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-lilypond
