On Sun, 2017-12-03 at 17:39 +0200, Orgad Shaneh wrote:
> On Fri, Jun 23, 2017 at 2:59 AM, Paul Smith <psm...@gnu.org> wrote:
> > On Tue, 2017-06-20 at 18:20 +0300, Eli Zaretskii wrote:
> > > > Date: Sun, 18 Jun 2017 17:42:51 +0300
> > > > From: Eli Zaretskii <e...@gnu.org>
> > > > Cc: alex...@gmail.com, bug-make@gnu.org
> > > > > I think the problem is that reap_children() is called after
> > > > > delete_child_targets, so the child jobs can still run
> > > > > while make is trying to delete.
> > > > >
> > > > > Maybe delete_targets should become part of reap_children (it
> > > > > cannot be called after reap, because at this
> > > > > point you don't have the target info anymore).
> > > > >
> > > > > What do you say?
> > > >
> > > > I will let Paul to chime in and comment about that. Failing
> > > > that, I
> > > > will push your changes after trying them on my box here.
> > >
> > > Paul, could you please comment on Orgad's proposal above?
> >
> > Conceptually I don't have any problems with the idea. I'd need to
> > dig
> > into the code more to be sure of any side-effects, and/or examine
> > any
> > posted solution carefully of course.
>
>
> Ping?
Seems OK to me.
_______________________________________________
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
