On Sep 16 2019, Paul Smith <psm...@gnu.org> wrote:

> On Thu, 2019-09-12 at 09:33 +0200, Andreas Schwab wrote:
>> On Sep 11 2019, Dmitry Goncharov <dgoncha...@users.sf.net> wrote:
>> > On Wed, Sep 11, 2019 at 2:51 AM Andreas Schwab <sch...@suse.de> wrote:
>> > > > The new hashing mechanism hashes differently on big vs little
>> > > > endian.
>> > > 
>> > > Should this be considered as a bug?
>> > 
>> > I don't think the order or removal of intermediate files was
>> > specified.
>> 
>> The testsuite obviously is depending on it.
>
> The test suite simply matches output strings, it's not very intelligent
> about stuff like that (unfortunately).
>
> I didn't apply this change because I'm not exactly sure where I want to
> go with this yet.  I'm not excited about tweaking the test suite based
> on the endianness of the underlying system but it seems silly to reduce
> the performance of the hash to make it consistent across endianness as
> well.

If the hash implementation is not defined, then the testsuite should
match any order, and not just based on endianess.

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

_______________________________________________
Bug-make mailing list
Bug-make@gnu.org
https://lists.gnu.org/mailman/listinfo/bug-make
  • vpathplus tes... Dmitry Goncharov via Bug reports and discussion for GNU make
    • Re: vpat... Andreas Schwab
      • Re: ... Dmitry Goncharov via Bug reports and discussion for GNU make
        • ... Andreas Schwab
          • ... Paul Smith
            • ... Andreas Schwab
              • ... Paul Smith

Reply via email to