At 2025-10-15T18:55:03+0200, Jakub Horký wrote: > + add kmnu including shifted variants to xterm+nofkeys
Please spell this 'kmenu'. The conventional maximum length of a
terminfo cap-code is 5 letters.[1] There's no good reason I can see to
make this one shorter, and not abbreviating it makes its meaning clear.
More generally, I suggest that your changes might face a better
reception if you
(1) broke them up into a series of logically separate patches, even
if this meant more overall churn, because then Thomas could reject
or postpone an individual item without doing (as much) violence to
the rest; and
(2) used building blocks as aggressively as possible at each stage of
(1), even if that causes more overall churn to the file.
But the foregoing is a guess; my prediction of the factors influencing
Thomas's receptiveness could be ill-premised.
Regards,
Branden
[1]
https://github.com/ThomasDickey/ncurses-snapshots/blob/4311b18dda3e30eed79bb7dca58cb52bab70c942/include/Caps#L203
signature.asc
Description: PGP signature
