Hans de Goede wrote:
> The current dasd label code keeps an fdasd anchor struct in the
> DasdDiskSpecific struct, and fills this during dasd_read. However this
> anchor does not get updated with any future mods, until dasd_write,
> at which points it gets completely re-initialized.
Thanks for these patches.
My first pass at reviewing them spotted only a few nits:
- it requires a test (outline is fine, as before)
- any fix like that deserves an entry in NEWS;
Please add an entry for your new alignment-related functions, while
you're at it.
- the new index, "int i" (in 2/5) should be declared "unsigned int i".
Also, please move the declaration so it is right before the first use:
i.e., declare it on the line right before the for-loop.
In general, please move declarations you add or touch "down"
to be as close to first use as possible.
_______________________________________________
bug-parted mailing list
bug-parted@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-parted
