On Thu, Oct 26, 2017, at 07:12, Chet Ramey wrote: > On 10/26/17 1:21 AM, Benjamin Peterson wrote: > > The layout of the _rl_search_cxt struct, defined in rlprivate.h, depends on > > whether HANDLE_MULTIBYTE is defined when the struct is defined. Since > > rlprivate.h doesn't include rlmbutil.h, the header responsible for defining > > or > > not defining HANDLE_MULTIBYTE, the layout of _rl_search_cxt will depend on > > whether the translation unit has included rlmbutil.h before it includes > > rlprivate.h. > > > > In particular, callback.c doesn't include rlmbutil.h but uses references > > variables of type _rl_search_cxt. This could easily be problematic in the > > future. > > Thanks for the report; this is a good catch. The best thing to do is > probably to include rlmbutil.h in rlprivate.h, as you suggest.
Excellent. Shall I send a patch or is it in your hands now? _______________________________________________ Bug-readline mailing list [email protected] https://lists.gnu.org/mailman/listinfo/bug-readline
