On 7/24/24 8:19 AM, Rudi Heitbaum wrote:
On Mon, Jul 22, 2024 at 11:04:31AM -0400, Chet Ramey wrote:
On 7/20/24 2:19 AM, Rudi Heitbaum wrote:
when compiled with -Wparentheses

I don't like that style, don't use it, and it seems a waste of time to
change the existing correct code just to silence a bogus compiler warning.

Hi Chet, Thanks for taking a look at the patch. I have to agree the
code is ugly avoiding the warning, was just going through our distro
build tidying up warnings. No issue either way, we will continue to
use the upstream release as-is as we dont want to manage local
patches when they really do nothing. :-)

I added something to make -Wno-parentheses the default like in bash. That
should fit your needs unless you force -Wparentheses.

Chet

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    c...@case.edu    http://tiswww.cwru.edu/~chet/


Reply via email to