[Bug-tar] savedir() error handling (was: error handling and exit code (patch for tar-1.20/1.21))

[Solar Designer]

Sergey,

On Tue, Aug 25, 2009 at 10:37:13AM +0300, Sergey Poznyakoff wrote:
> Solar Designer <so...@openwall.com> ha escrit:
> >   char *dirp = savedir (dir);   /* for scanning directory */
> > [...]
> >   if (! dirp)
> >     savedir_error (dir);
> > 
> > Perhaps we need to patch this in our usual way?
> 
> Looks reasonable. I'll see what can be done.

I just had this occur (TAREXIT_FAILURE on a removed deep directory) on a
system that was already running 1.22.90-owl1, confirming that it is
indeed still affected.

Are you going to propose a patch for this, or should I?

tar: ./home/clients/websites/w_client/drupal/5.10/cache/example.org/0/group: 
Cannot savedir: No such file or directory
tar: ./home/clients/websites/w_client/drupal/5.10/cache/example.org/0/group: 
Directory removed before we read it
tar: ./home/clients/websites/w_client/drupal/5.10/cache/example.org/0/solution: 
Cannot savedir: No such file or directory
tar: ./home/clients/websites/w_client/drupal/5.10/cache/example.org/0/solution: 
Directory removed before we read it
tar: ./home/clients/websites/w_client/drupal/5.10/cache/example.org/0/group: 
File removed before we read it
tar: 
./home/clients/websites/w_client/drupal/5.10/cache/example.org/0/blog.html: 
File removed before we read it
[...]
tar: 
./home/clients/websites/w_client/drupal/5.10/cache/example.org/0/node/3111.html:
 File removed before we read it
tar: Exiting with failure status due to previous errors

Thanks,

Alexander