On Wed, 10 Mar 2010, Dmitry V. Levin wrote:
On Wed, Mar 10, 2010 at 02:55:40PM +0200, Sergey Poznyakoff wrote:
I am pleased to announce the release of GNU tar version 1.23.
There is a new compilation warning in this release:
names.c: In function 'collect_and_sort_names':
names.c:874: warning: 'prev_name' may be used uninitialized in this function
The warning is not a false alarm this time. I've looked at the code
and confirm that this variable is used uninitialized.
With gcc-3.4.6 I don't get this warning, but configuring with
'--disable-nls' I get two others:
../../tar-1.23/src/tar.c: In function `tar_help_filter':
../../tar-1.23/src/tar.c:1290: warning: assignment discards qualifiers from
pointer target type
../../tar-1.23/src/tar.c:1294: warning: assignment discards qualifiers from
pointer target type
to be removed by this patch:
diff -ur tar-1.23.orig/src/tar.c tar-1.23/src/tar.c
--- tar-1.23.orig/src/tar.c 2010-03-09 13:52:41.000000000 +0100
+++ tar-1.23/src/tar.c 2010-03-10 16:54:09.902762948 +0100
@@ -1253,7 +1253,7 @@
tar_help_filter (int key, const char *text, void *input)
{
struct obstack stk;
- char *s;
+ const char *s;
switch (key)
{
The result of gettext() really ought to be treated as const (in spite of the
prototype).
Regards
Peter Breitenlohner <[email protected]>
