Hi, On Tue, Oct 29, 2013 at 08:03:47AM -0400, Andrew J. Schorr wrote: > Thanks for the patch, but I don't think that fixes the problem in > sparse.c:sparse_scan_file where it says > > if (ST_NBLOCKS (st->stat) == 0) > offset = st->stat.st_size; > else > ...
To be clear, I can see that the fix to ST_IS_SPARSE should cause dump_regular_file to be called instead of sparse_dump_file, but I still wonder if it is wise to leave this logic in place. At the very last, I think a comment would be helpful to explain that this test is valid only because ST_IS_SPARSE has already succeeded. Regards, Andy
