On Thursday 17 of March 2016 10:45:28 Sergey Poznyakoff wrote:
> I plan to release 1.29 within 7-10 days. I'm aware of several still
> pending issues, but these don't seem to be important enough to justify
> further delays. Please, correct me if I'm wrong. Paul, Pavel - your
> opinions?
There is one infinite loop issue which could potentially deserve a minute:
http://lists.gnu.org/archive/html/bug-tar/2014-03/msg00052.html
Also the slightly adjusted (attached) patch for xattrs configure-detection
might help at least to OS X (no need to pass --without-xattrs?):
http://lists.gnu.org/archive/html/bug-tar/2014-08/msg00003.html
Other patches (I touched) can probably wait for 1.30, I'll check.
The v1.29 would bring the SEEK_HOLE SEEK_DATA implementation, so sparse
file archiving might be good candidate for pre-release testing.
Thanks,
Pavel
>From c58fa39d546dc7284f03398e2beb8d0fce614ef0 Mon Sep 17 00:00:00 2001
From: Pavel Raiskup <address@hidden>
Date: Mon, 4 Aug 2014 13:19:49 +0200
Subject: [PATCH] xattrs: fix bug in configure
Define HAVE_XATTRS only when all needed xattr-related functions
are available (either in libc or libattr).
Reported independently by Denis Excoffier and Dominyk Tille.
* acinclude.m4 (TAR_HEADERS_ATTR_XATTR_H): Check for each xattr
function separately. Don't AC_CHECK_LIB (LIBS is filled by
AC_SEARCH_LIBS when necessary).
* src/Makefile.am: The LDADD -lattr was redundant.
---
acinclude.m4 | 42 ++++++++++++++----------------------------
src/Makefile.am | 4 ----
2 files changed, 14 insertions(+), 32 deletions(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 812340b..ca90285 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -40,37 +40,23 @@ AC_DEFUN([TAR_HEADERS_ATTR_XATTR_H],
# First check for <sys/xattr.h>
AC_CHECK_HEADERS([sys/xattr.h])
AM_CONDITIONAL([TAR_COND_XATTR_H],[test "$ac_cv_header_sys_xattr_h" = yes])
- AM_CONDITIONAL([TAR_LIB_ATTR],[false])
- if test "$ac_cv_header_sys_xattr_h" = yes; then
- AC_CHECK_FUNCS(getxattr fgetxattr lgetxattr \
- setxattr fsetxattr lsetxattr \
- listxattr flistxattr llistxattr,
- # only when functions are present
- AC_DEFINE([HAVE_SYS_XATTR_H], [1],
- [define to 1 if we have <sys/xattr.h> header])
- if test "$with_xattrs" != no; then
- AC_DEFINE([HAVE_XATTRS],,[Define when we have working linux xattrs.])
- fi
- )
- fi
-
- # If <sys/xattr.h> is not found, then check for <attr/xattr.h>
if test "$ac_cv_header_sys_xattr_h" != yes; then
AC_CHECK_HEADERS([attr/xattr.h])
AM_CONDITIONAL([TAR_COND_XATTR_H],[test "$ac_cv_header_attr_xattr_h" = yes])
- AC_CHECK_LIB([attr],[fgetxattr])
- AM_CONDITIONAL([TAR_LIB_ATTR],[test "$ac_cv_lib_attr_fgetxattr" = yes])
- if test "$ac_cv_header_attr_xattr_h" = yes; then
- AC_CHECK_FUNCS(getxattr fgetxattr lgetxattr \
- setxattr fsetxattr lsetxattr \
- listxattr flistxattr llistxattr,
- # only when functions are present
- AC_DEFINE([HAVE_ATTR_XATTR_H], [1],
- [define to 1 if we have <attr/xattr.h> header])
- if test "$with_xattrs" != no; then
- AC_DEFINE([HAVE_XATTRS],,[Define when we have working linux xattrs.])
- fi
- )
+ fi
+
+ if test "$with_xattrs" != no; then
+ for i in getxattr fgetxattr lgetxattr \
+ setxattr fsetxattr lsetxattr \
+ listxattr flistxattr llistxattr
+ do
+ AC_SEARCH_LIBS($i, attr)
+ eval found=\$ac_cv_search_$i
+ test "$found" = "no" && break
+ done
+
+ if test "$found" != no; then
+ AC_DEFINE([HAVE_XATTRS],,[Define when we have working linux xattrs.])
fi
fi
])
diff --git a/src/Makefile.am b/src/Makefile.am
index dc05d5c..08fc24c 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -53,7 +53,3 @@ AM_CFLAGS = $(WARN_CFLAGS) $(WERROR_CFLAGS)
LDADD = ../lib/libtar.a ../gnu/libgnu.a $(LIBINTL) $(LIBICONV)
tar_LDADD = $(LIBS) $(LDADD) $(LIB_CLOCK_GETTIME) $(LIB_EACCESS) $(LIB_SELINUX)
-
-if TAR_LIB_ATTR
-tar_LDADD += -lattr
-endif
--
2.5.5
