On Thu, Aug 21, 2014 at 10:30:45PM +0000, Karl Berry wrote:
> except that I would have placed it a bit later. I'll do it and commit.
>
> 1) It seems your patch did not remove my block, so now those four lines
> are in two places.
Are you sure it isn't a local non commited modification?
>
> 2) In fact, I originally tried putting it later in the fn, which looks
> more natural given the existing code. However, I found that it does not
> have any effect if it is any later than it is. Experimentally, I
> determined that it has to be before the line:
> $self->push_top_formatter('_Root_context');
Indeed you are right. I didn't test enough... I changed the location
of $self->push_top_formatter('_Root_context'); instead. Thanks! I
commited the change.
Since I used you in the log it will be as if you did the mistake though
;-)
--
Pat
