On Tue, Jun 30, 2015 at 12:31:50AM +0100, Gavin Smith wrote: > On 29 June 2015 at 20:24, Patrice Dumas <[email protected]> wrote: > >> I didn't want to write the C code to process underlying text > >> along with the main text, and also there may be performance > >> implications in doing things twice. So I've changed the code to use a > >> different approach. This is to insert a marker character, that will > >> not appear in the output, before a ., ? or ! which is allowed to > >> terminate a sentence in spite of a preceding upper-case letter. This > >> might seem like a hack, but it won't cause any problems because the > >> marker character used won't be passed in the argument otherwise, and > >> it was easy to implement the interpretation of this in XSParagraph. > > > > I do not like that much that kind of tricks, but if it works... Also, > > the Paragraph.pm, Line.pm and Unfilled.pm were meant to be independent > > with a (well) defined API. With this change, it seems that the calling > > code could need to know that there is a specific marker character that > > may be inserted. > > I don't see why this can't still be the case. I'll add some comments > next to the functions explaining how the marker character can be used, > unless there's documentation somewhere else I should add it to?
It seems to me to break the idea that user of an API should not care about implementation details. -- Pat
