On Tue, Aug 25, 2015 at 10:41:39PM +0100, Gavin Smith wrote: > On 25 August 2015 at 22:05, Patrice Dumas <[email protected]> wrote: > > Hello, > > > > 2 very minor reports. > > > > doc/test-texinfo-tex.texi seems to be missing from the repository. > > It's supposed to be doc/texinfo-tex-test.texi. Did I get the name > wrong somewhere?
Indeed, in EXTRA_DIST. > > The _GNU_SOURCE define in XSParagraph/text.c and XSParagraph/xspara.c > > look spurious to me. If they are not, there should be some comment > > explaining why they are needed. Also, if they are needed, they should > > probably be set up in configure.ac, if only to have them defined for > > other autoconf macros. > > I agree. It was probably likely for some function like asprintf. > There's likely something that is recommended to use with gnulib > instead. In fact gnulib already defines _GNU_SOURCE, probably through AC_USE_SYSTEM_EXTENSIONS, so I think that it should never be added for gnulib as gnulib should already set it. I commited the minor fixes for those 2 issues. -- Pat
