> Date: Sat, 6 Feb 2016 19:32:03 +0000 > From: Gavin Smith <[email protected]> > Cc: Texinfo <[email protected]>, Ken Brown <[email protected]> > > > --- tp/Texinfo/Convert/XSParagraph/xspara.c~0 2016-01-23 > > 13:31:17.000000000 +0200 > > +++ tp/Texinfo/Convert/XSParagraph/xspara.c 2016-02-06 > > 20:30:33.083250000 +0200 > > @@ -198,6 +198,16 @@ iswupper (wint_t wc) > > return 1; > > } > > > > +/* Avoid warnings due to redefinition of popen/pclose in Perl headers. */ > > +#ifdef popen > > +# undef popen > > +# define popen(c,m) _popen(c,m) > > +#endif > > +#ifdef pclose > > +# undef pclose > > +# define pclose(f) _pclose(f) > > +#endif > > + > > #endif > > I see this code is in the #ifdef _WIN32 section, so I'm happy with it > even if I don't understand it.
OK, I will install that. I did it in the MS-Windows specific code, because I don't know how to solve this for other platforms -- _popen and _pclose only exist on Windows, AFAIK. > One worry I have is why Perl is redefining popen/pclose in the first > place and if problems could occur on other systems, like Cygwin. (Ken > cc'd). There's a whole bunch of such redefinitions starting around line 500 in XSUB.h, so I think it will affect other platforms as well, not only Windows. I have no idea why it does that.
