On Wed, Jun 07, 2017 at 03:07:14PM -0400, Ken Brown wrote:
> >So I guess it should be
> >
> >host_is_windows=no
> >case "$host" in
> >     *-mingw32 | *-mingw64 | *-msdosdjgpp | *-cygwin )  host_is_windows=yes 
> > ;;
> >esac
> >AM_CONDITIONAL([HOST_IS_WINDOWS], [test "x$host_is_windows" = "xyes"])
> 
> Yes, that would do it.  My only suggestion is that it might be better to use
> something like HOST_NEEDS_NO_UNDEFINED rather than HOST_IS_WINDOWS. Having
> HOST_IS_WINDOWS defined on Cygwin could cause confusion in the future if
> someone wants to introduce Windows-specific code, since such code usually
> isn't appropriate for Cygwin.  The need for -no-undefined is an 
> exception.

Thank you, I've changed it as you suggested.

Reply via email to