Hans-Bernhard Bröker <[email protected]> writes: > Am 22.09.2017 um 12:26 schrieb Mathieu Lirzin: > >> My patch was missing this configure.ac change: >> >> --8<---------------cut here---------------start------------->8--- >> AC_CONFIG_FILES([pre-inst-env:build-aux/pre-inst-env.in], >> [chmod +x pre-inst-env]) >> --8<---------------cut here---------------end--------------->8--- >> >> with that, it should not be necessary to mention build-aux/ in >> Makefile.am. > > Doing it that way, combined with the addition of > > CLEANFILES= $(noinst_SCRIPTS) > > to Makefile.am, would appear to break the usual symmetry rules for the > cleaning targets: "make clean" should only remove stuff that "make" > built. Stuff built by "configure" or "config.status" is supposed to > only be removed by "distclean". > > I.e. with the above, a > > ./configure > make > make clean > make > > run would tend to end up with the pre-inst-env file missing.
That is not the case, 'pre-inst-env' is rebuilt. :-) However, I agree with your reasoning that 'make clean' should not remove things generated by configure. Fixed in revision 7963, Thanks. -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
