On Fri, Jan 18, 2019 at 11:52:33PM +0100, Bruno Haible wrote: > There are two test failures: > > FAIL: ii-0041-test > FAIL: ii-0050-test > > The log for ii-0041-test contains this: > > + findprog zdiff > + zdiff ../../../install-info/tests/ii-0041-expected-dir-file.gz > /tmp/haible015772.gz > Warning : missing newline at end of file > ../../../install-info/tests/ii-0041-expected-dir-file.gz > Warning : missing newline at end of file /tmp/haible015772.gz > 1c1 > <`�oG > --- > > � > + retval=1
Indeed, I looked at a hex dump of ii-0041-expected-dir-file.gz and "oG" is near the start of the file. It's not comparing the uncompressed files properly. Maybe the HP-UX zdiff doesn't support gzip format. I found this old report: https://lists.gnu.org/r/bug-texinfo/2013-02/msg00030.html > * HP-UX 11 ships with two zdiff binaries (in /usr/bin and /usr/contrib/bin) > and > tends > to pick the "non-gzip" version in /usr/bin with the default PATH. To get > around > this, I put /usr/contrib/bin in front of the PATH just before zdiff is run > (line 21 in install-info/tests/ii-0041-test and line 22 in > install-info/tests/ii-0050-test): I don't think this is a very important issue to fix. I'm not sure how it could be fixed: * Bundle zdiff with texinfo * Avoid using zdiff and replicate its functionality in the test scripts using more standard tools. * Check whether zdiff works as expected and skip the test if it doesn't. This would be easier than the previous two options. Does the default zdiff with HPUX have a --version output that we could check? Or maybe we could just do zdiff --version | grep gzip to check it is the version that comes with gzip. It is only two tests, after all.
