strerror return value

[Philipp Klaus Krause]

This is just a very minor issue.

texinfo contains two calls to strerror where the result is used to
initialize or assign to a char *. However, according to the strerror
specification, the string returned by strerror should never be changed,
so I think it would be better to use const char * instead.

Besides these two, there are further such calls in texinfo via in
gnulib. I guess texinfo doesn't want to diverge from the gnulib version
that was once pulled in over this issue (and upstream gnulib has fixed
them by now anyway, so the problematic use in texinfo will disappear by
itself sometime a newer gnulib is pulled in).

Philipp

diff --git a/info/filesys.c b/info/filesys.c
index 52b624178..4f4564486 100644
--- a/info/filesys.c
+++ b/info/filesys.c
@@ -539,7 +539,7 @@ char *
 filesys_error_string (char *filename, int error_num)
 {
   int len;
-  char *result;
+  const char *result;
 
   if (error_num == 0)
     return NULL;
diff --git a/install-info/install-info.c b/install-info/install-info.c
index 21f4fe3e5..45feb1d8f 100644
--- a/install-info/install-info.c
+++ b/install-info/install-info.c
@@ -632,7 +632,7 @@ ensure_dirfile_exists (char *dirfile)
   if (desc < 0 && errno == ENOENT)
     {
       FILE *f;
-      char *readerr = strerror (errno);
+      const char *readerr = strerror (errno);
       f = fopen (dirfile, "w");
       if (f)
         {