On Sat, Oct 31, 2020 at 07:39:32PM +0000, Gavin Smith wrote:
> On Sat, Oct 31, 2020 at 07:47:29PM +0100, Patrice Dumas wrote:
> > Hello,
> > 
> > I propose to change the SHOW_MENU possible values to use only strings 
> > to have something more consistent and logical.  I propose the following 
> > change:
> > 0 -> nomenu
> > 1 -> menu
> > 
> > Also, but that may not be so important, SHOW_MENU could be renamed to
> > something that corresponds more to the new meaning, like FORMAT_MENU.
> 
> Using all words would be better.  I had been concerned about backwards
> compatibility. Maybe changing it to FORMAT_MENU would be better to
> avoid confusion with the old meaning.

I agree.  Do you want that we keep a SHOW_MENU variable for backward
compatibility?  I do not think this is useful, users should change their
code.

-- 
Pat

Reply via email to