On Fri, Aug 04, 2023 at 05:10:15PM +0100, Gavin Smith wrote: > That is me mostly done now.
The code looks good to me, but it should not be in Texinfo::Common, because it depends on Texinfo::Structuring, and maybe even worse on Texinfo::Translations. It should be in Texinfo::Structuring, with a dependency on Texinfo::Translations added in Texinfo::Structuring, which seems ok to me. > The only thing I noticed was that in texinfo.texi, when generating the > top-level menu, that the "Appendices" comment would be lost before the > links to the appendices. I don't know if it is worth adding special code > just to output this comment in the menu. Could be added to the TODO. > I also had to delete the joke after the menu as the automatically > generated menu will be the very last thing in the node. Perhaps we > could hide a joke somewhere else in the file? The Info format specification would seem a possible place to me. -- Pat
