On Tue, Sep 19, 2023 at 08:33:08PM +0100, Gavin Smith wrote: > > This shows how using new gnulib modules can lead to problems, especially > under the tp/Texinfo/XS directory.
We need to use libunistring quite a bit to be on par with the perl code on everything related to unicode. > I don't know what problem the libunistring module was supposed > to fix. Commit 3ded9f090 (2023-09-01) adds the module but it's not > clear how or why it's used - I couldn't see anything in nearby commits. It is needed, it was an oversight of me not to add it previously, it has been needed since I added uniconv/u8-strconv-from-enc unistr/u8-mbsnlen in https://git.savannah.gnu.org/cgit/texinfo.git/commit/?id=0bfbc74287b9b85c63f9fc850d17b035e8aa32fb I added a retrospective Changelog more recently in https://git.savannah.gnu.org/cgit/texinfo.git/commit/?id=0e484c586858de92a8ec7850d96472d3c22d6afa > Could we not just revert adding the module and that would fix the > problem? No, and it would even fail if the system libunistring is used, it is that failure that made me realize that this module was needed. -- Pat
