On Sun, Nov 05, 2023 at 12:13:00PM +0100, Arsen Arsenović wrote:
>
> Seems that relatively many things changed between 6.x and 7.0.
7.0 was the first release with an official HTML customization API. The
API is not stable yet, as the many changes between 7.0 and 7.1 and the
changes already in master show, but it is still less changes than
between 6.8 and 7.0.
> +sub ffmpeg_file_header_info($$)
> +{
> + my $self = shift;
> + my $command = shift;
> + return $self->_file_header_information($command) if $program_version_7_0;
> + reutrn $self->_file_header_informations($command);
> +}
A typo above for reutrn.
>
> @@ -201,9 +213,9 @@ if ($program_version_6_8) {
> sub ffmpeg_program_string($)
> {
> my $self = shift;
> - if (defined($self->get_conf('PROGRAM'))
> - and $self->get_conf('PROGRAM') ne ''
> - and defined($self->get_conf('PACKAGE_URL'))) {
> + if (defined(texinfo_get_conf('PROGRAM'))
> + and texinfo_get_conf('PROGRAM') ne ''
> + and defined(texinfo_get_conf('PACKAGE_URL'))) {
Not sure that it is relevant, but PACKAGE_URL is PACKAGE_URL_OPTION in
master.
> return $self->convert_tree(
> $self->gdt('This document was generated using
> @uref{{program_homepage}, @emph{{program}}}.',
> { 'program_homepage' => $self->get_conf('PACKAGE_URL'),
Same here for PACKAGE_URL_OPTION.
> Does this patch seem reasonable to you?
Other than my comments above, yes, looks good.
--
Pat
