Hello,

The CI at github for the mingw on cygwin leads to failing link of info
with:
/usr/lib/gcc/i686-w64-mingw32/13/../../../../i686-w64-mingw32/bin/ld: 
run-external.o: in function `get_output_from_program':
/cygdrive/d/a/ci-check/ci-check/texinfo-7.2.20250729dev/build/info/../../info/run-external.c:119:(.text+0x1b9):
 undefined reference to `WEXITSTATUS'

configure does not find <sys/wait.h>.

So, there may be a need for some portability for the case of missing
<sys/wait.h> (and no definition of WEXITSTATUS). 


Maybe minor, and I may have missed something as I am a beginner here,
but I read the man pages for WEXITSTATUS and pclose, and the code does
not seem to follow my understanding of the documentation (maybe on
purpose). 

* on line 111
 exit_status = pclose (fpipe);
  Upon my reading of the pclose man page it seems to me that before considering
  exit_status as an exit status, it should be checked if not < 0, and if
  < 0 check errno / give an error message or keep errno somewhere. 

* on line 119 there is 
 return WEXITSTATUS(exit_status); 
  without checking first that WIFEXITED(exit_status) returned true, ie
  that there was a proper exiting 

Again I may be totally off.

-- 
Pat

Reply via email to