> From: Gavin Smith <[email protected]> > Date: Tue, 20 Jan 2026 21:13:43 +0000 > Cc: [email protected], [email protected] > > On Fri, Jan 16, 2026 at 06:03:04PM +0200, Eli Zaretskii wrote: > > In addition, the !PIPE_USE_FORK branch of get_output_from_program had > > a few problems: it failed to use the FILENAME argument when > > constructing the command line for popen, used the null > > formatter_args[2] in sprintf, and had a few other minor issues. > > > > Here's the patch to fix all that, after which all Info tests pass. I > > will see about writing a Windows batch file that works like > > info/info-hooks-default/manual-not-found, so that "make install" could > > install it. > > I've committed this, except for moving one line: "free (cmdline);". > This moved the 'free' after a possible return statement ("return 127;"), > which would be a memory leak if that return statement were run. > > Please let me know if there is a problem with running "free" on > the argument to "popen" before calling "pclose".
No problem, thanks.
