On Mon, Feb 02, 2026 at 11:47:03PM +0100, Patrice Dumas wrote:
> > The whole point of the BUILD_C_CODE condition was not to build C code
> > under tta/ if it was not necessary.
> 
> Ok.  I also propose for that condition to be used to build some code
> that depends on the code build by BUILD_C_CODE.
> 
> > There may be some reason that some other condition is also needed just
> > for the auxiliary, non-XS dynamic libraries (libtexinfo and so on) but
> > that was not the main point of the change.
> >
> > > To me it is clearer.  Indeed, the HAVE_ICONV was used to mean that some
> > > code depends indirectly on the iconv library through the shared
> > > libraries.  A conditional like SHARED_TXI_LIBRARIES_BUILT is clearer to
> > > me as it the texinfo shared libraries are a direct dependency of the
> > > code that may not use iconv directly.
> > 
> > I agree that SHARED_TXI_LIBRARIES_BUILT (or whatever it's called) would
> > be better at expressing this dependency than HAVE_ICONV.
> 
> But are you ok to use SHARED_TXI_LIBRARIES_BUILT instead of
> BUILD_C_CODE?

I think I've explained my opinion as clearly as I can.

I will try to work out a patch.

  • erro... Bruno Haible via Bug reports for the GNU Texinfo documentation system
    • ... Gavin Smith
      • ... Patrice Dumas
        • ... Gavin Smith
          • ... Patrice Dumas
            • ... Gavin Smith
              • ... Patrice Dumas
                • ... Gavin Smith
                • ... Patrice Dumas
                • ... Gavin Smith
                • ... Gavin Smith
                • ... Patrice Dumas
                • ... Bruno Haible via Bug reports for the GNU Texinfo documentation system
      • ... Gavin Smith

Reply via email to