On Sat, May 30, 2026 at 04:53:44PM +0200, Patrice Dumas wrote: > On Sat, May 30, 2026 at 09:14:57AM +0100, Gavin Smith wrote: > > On Fri, May 29, 2026 at 07:28:39PM +0200, Patrice Dumas wrote: > > > Hello, > > > > > > Now that there is always unicode collation for C, I would propose to > > > have the same requirement for Perl, that is require Unicode::Collate > > > to be present. Nowadays, texi2any in pure Perl is a different option, > > > mainly relevant for users in case of issues with C, I think that it > > > would be better if the pure Perl option had the same features as the C > > > command. > > > > That sounds like a good idea. We have had issues in the past of the > > fallback code (Texinfo::CollateStub) not being tested and having problems. > > I also remember that, but I believe that it is the fallback itself that > was problematic, as it there is at least some testing of > Texinfo::CollateStub through setting USE_UNICODE_COLLATION=0 when one > test with TEXINFO_XS=omit, something I try to do for all changes.
Yes, it could have been the code trying to load Unicode::Collate and then falling back which wasn't regularly tested. The case of a customization variable with a certain value (USE_UNICODE_COLLATION=0) is different and easy to test, as you say.
