On Fri, May 12, 2000 at 10:24:17PM +0200, Jim Meyering wrote:
> Here's the fix (relative to the latest test release).
...
> Index: head.c
> ===================================================================
> RCS file: /fetish/textutils/src/head.c,v
> retrieving revision 1.57
> diff -u -p -r1.57 head.c
> --- head.c    1999/04/24 12:33:25     1.57
> +++ head.c    2000/05/12 20:20:02
> @@ -223,7 +223,7 @@ string_to_integer (int count_lines, cons
>    strtol_error s_err;
>    uintmax_t n;
>  
> -  s_err = xstrtoumax (n_string, NULL, 0, &n, "bkm");
> +  s_err = xstrtoumax (n_string, NULL, 10, &n, "bkm");
>  
>    if (s_err == LONGINT_INVALID)
>      {

BINGO.  It had been using the "default" behaviour of the function -
whatever that was.  But 'head' is not defined to do so.

Joe's First Law of Software Engineering: "Say What You Mean."  You know
what happens when you assume.  [First amendment to first law - "and then
document it."  Notice the comment above?  Neither did I.  ;-}]

-- 
/*********************************************************************\
**
** Joe Yao                              [EMAIL PROTECTED] - Joseph S. D. Yao
**
\*********************************************************************/

Reply via email to