-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hrvoje Niksic wrote: > Micah Cowan <[email protected]> writes: > >> But then when I actually got a chance to look at the patch, saw how >> trivial it was. I committed something close, but not identical, to it >> (particularly for hash.c): >> http://hg.addictivecode.org/wget/mainline/rev/1f5794065912 > > Note that hash.c is supposed to be useful outside Wget and without > config.h. (I've used it in various other projects that needed a nice > and simple nice hash table implementation.) hash.c is supposed to be > pure ISO C anyway, relying on a minimal number of system interfaces, > which is why I hoped such self-sufficient checks might cut it for that > file.
Hm... well, what about a check for C99 first, and then a fallback on checking for HAVE_STDINT_H? Or, I suppose we could consider assuming an unsigned long is large enough to hold a pointer, and eschew the use of uintptr_t. Or look into how it might be possible to avoid casting a pointer to an integer type. - -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer. Maintainer of GNU Wget and GNU Teseq http://micah.cowan.name/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAknx/L0ACgkQ7M8hyUobTrEtVwCeKSxbP70nEHGBJpKRaqpZ9/oj qj8An2r0Nh+sLsiYhCWWP1AjOYtEQOvL =4Bjk -----END PGP SIGNATURE-----
