-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Steven M. Schweda wrote: > From: Micah Cowan > >>> (I didn't "improve" the vsnprintf() prototype, because it needs >>> "va_list", which not universally available. A realistic snprintf() >>> seems to be harmless around here, however.) >> "Not universally available"? It's part of the C standard, since 1989. >> And it surely must exist on your platform, since if that #if clause is >> firing, then so is the one in snprintf.c, whose snprintf implementation >> uses vsnprintf (and therefore va_list), and apparently doesn't fail to >> compile. > > Poor phrasing on my part. "src/sysdep.h" didn't already pull in a > declaration of "va_list", so merely dropping in the realistic prototype > for vsnprintf() caused more problems than it solved, and I didn't want > to start tossing in #include directives to pull in <stdarg.h> or > <varargs.h> or <I_don't_know_what_else.h>, which might not be portable. > (But _you_ can.)
Ah; I understand. This is what I've done, though my confidence that sticking an #include right there won't break anything is only fair-to-middlin'. But I imagine we can move it up higher in the file if it does. >> Is vms/getopt.h just copied from lib/getopt.in.h? I assumed it was, and >> made this change. > > The new builders have been copying "lib/getopt.in.h" to "getopt.h" > (in a product directory, not "vms/"), and getting it from there. I > could keep doing that. Or, if it's easy and not odious, and you'd like > to supply it as "vms/getopt.h", then I could rip out a few lines. Not > having to deal with what happens to a multi-dot file name on an ODS2 > disk would be ok with me, and I believe that that's the only one. Ah. I guess I misunderstood; thought it was something you wanted me to do to the sources. I'll pull that stuff back out. But I'll leave the move of vms/vms.c to src/vms.c. - -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer. Maintainer of GNU Wget and GNU Teseq http://micah.cowan.name/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkq8+jcACgkQ7M8hyUobTrHy4QCggWxUbU+9IVhG/WpLCsvrJ0p8 xCwAoIXji3XXKerI7VUyB7M18kpAhxnH =Rz89 -----END PGP SIGNATURE-----
