Am Wednesday 14 November 2012 schrieb Daniel Stenberg: > On Wed, 14 Nov 2012, Tim Ruehsen wrote: > > as David Ryskalczyk stated, just two printf format specifiers might cause > > the havoc. I think, there is not need to use wgint instead of off_t. > > > > @Guiseppe: please apply the appended patches (maybe adding them together > > into one commit) > > Don't you still build wget on C89 systems without long long and 64 bit > support?
Ouch. Good point. But then, compiling Wget with -std=c89 won't work at all. Using -std=gnu89 -pedantic tells us why Wget won't compile with a c89-only compiler (just an excerpt): gettext.h:248:3: warning: ISO C90 forbids variable length array 'msg_ctxt_id' gnutls.c:89:3: warning: ISO C90 forbids mixed declarations and code iri.c:101:12: warning: ISO C forbids braced-groups within expressions warc.c:535:3: warning: C++ style comments are not allowed in ISO C90 main.c:210:33: warning: ISO C forbids conversion of function pointer to object pointer type ../lib/regex.h:653:26: warning: ISO C90 does not support 'static' or type qualifiers in parameter array declarators Taking this into account: is there any good point in not using long long ? The code is already "polluted" by c99 stuff. Regards, Tim
