Hi Giuseppe,
Dropping the bit that sanitizes the opt.method is probably a good idea.
(Perhaps I shouldn't have replied to your patch directly.)
Still, even if the sanitization is removed: I think it would be better
if RESTORE_POST_DATA restores the previous value of opt.method, instead
of overwriting it with a hardcoded "POST". Isn't it?
A related question: how is a redirect response to a PUT request handled?
How should it be handled?
I haven't tried it, but it looks like in that case the SUSPEND_POST_DATA
macro is called (by retrieve_url in retr.c). If that's true, then later
on the opt.method would be 'restored' to "POST" by RESTORE_POST_DATA.
Regards,
Gijs
Op 01-05-13 22:16 schreef Giuseppe Scrivano:
hi Gijs,
Gijs van Tulder <gvtul...@gmail.com> writes:
Giuseppe Scrivano wrote:
what about this patch? Any comment?
Another suggestion: why not save the original opt.method, set
opt.method to NULL and put the original opt.method back later?
thanks for your suggestion but I think we should drop the code that
modifies opt.method, since we have to sanitize it only when it is
specified as argument. Objections?
