Darshit Shah <[email protected]> writes:

>>
>> In comment to `request_new` was that it *always* must be followed by
>> `request_set_method`. I changed code to combine these functionality into
>> single function. Please, review.

>
> Looks good to me.
> Just one thing though, the method string is now converted to uppercase
> through cmd_string_uppercase.
> Giuseppe pushed a patch with that change a few days ago..  Please rebase it 
> onto the master branch.

Good idea, but as Darshit said, please rebase it onto the master branch.

I will be offline for the next few days, I will review it when I am back.

-- 
Giuseppe

Reply via email to