Hi, The 1.14.128 alpha release that was announced to the translators contains a few messages that have some defects.
One is that the string: "Cookie coming from %s attempted to set domain to %s" was changed to: "Cookie coming from %s attempted to set domain to " This is not good, as some languages may require the domain name _not to be at the end. In general messages should be complete sentences, with all subjects and objects included. Attached patch fixes this. In the help text, the option --metalink-file lacks a FILE argument, and the options --retries and --jobs lack a NUMBER argument. I would make a patch for this too, but the relevant code is not in git?? The phrase: "Username and password information not needed to be specified when downloading from a metalink." contains too many spaces, and would be better worded as: "...information do not need to be specified...". Also this code I cannnot find in git, otherwiose I'd make a patch. Regards, Benno -- http://www.fastmail.fm - A fast, anti-spam email service.
From 2a6bb291df10cc699a5ba46312b76d57962eaa04 Mon Sep 17 00:00:00 2001 From: Benno Schulenberg <[email protected]> Date: Sun, 2 Jun 2013 12:08:35 +0200 Subject: [PATCH] Make an error message a complete sentence. Signed-off-by: Benno Schulenberg <[email protected]> --- src/cookies.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/cookies.c b/src/cookies.c index 4efda88..9dba460 100644 --- a/src/cookies.c +++ b/src/cookies.c @@ -684,10 +684,8 @@ cookie_handle_set_cookie (struct cookie_jar *jar, if (!check_domain_match (cookie->domain, host)) { logprintf (LOG_NOTQUIET, - _("Cookie coming from %s attempted to set domain to "), - quotearg_style (escape_quoting_style, host)); - logprintf (LOG_NOTQUIET, - _("%s\n"), + _("Cookie coming from %s attempted to set domain to %s."), + quotearg_style (escape_quoting_style, host), quotearg_style (escape_quoting_style, cookie->domain)); cookie->discard_requested = true; } -- 1.7.0.4
