Ángel González <[email protected]> writes: > I noticed a gcc warning on cmd_string_uppercase() and ended up almost > rewriting it, since I disliked the extra copy by cmd_string. > > Also note that the if (!ret || q == NULL) was useless, since > cmd_string always returns true, and q would never be NULL (it would > have crashed inside xstrdup, see gnulib/lib/xmalloc.c).
thanks, I have added the ChangeLog entry and pushed it. -- Giuseppe
