Hi, Thanks for the refactoring. However, you've included makefile and makefile.in which are autogenerated files and should not be commited.
Also, your patch has trailing whitespace errors. And I don't think you've added an entry to ChangeLog either. Please look into these. I haven't seen your patch yet. The Makefile errors mean I can't apply it without a lot of extra work. On Sat, Mar 8, 2014 at 5:38 PM, 陈子杭 (Zihang Chen) <[email protected]>wrote: > Hi. > > Here's a patch refactoring CommonMethods, HTTPTest and project hierarchy. > 19 tests passed, 1 xfailed as expected. > > Let me know if there's any problem. > > -- > Regards, > Chen Zihang, > Computer School of Wuhan University > --- > 此致 > 陈子杭 > 武汉大学计算机学院 > -- Thanking You, Darshit Shah
