On Fri, Mar 21, 2014 at 10:54 AM, Giuseppe Scrivano <[email protected]> wrote:
> Yousong Zhou <[email protected]> writes:
>
>> This series tries to add an option `--start-pos' for specifying starting
>> position of a HTTP or FTP download. Also inclued are 3 fixes for the test
>> infrastructure and 3 test cases for the new option.
>>
>> With the new option, a user-specified zero-based offset value can be
>> specified,
>> instead of deriving it from existing file which is what --continue currently
>> does. When both this option and --continue are both specified which does not
>> make much sense, wget will warn and proceed as if --continue was not there.
>>
>> Signed-off-by: Yousong Zhou <[email protected]>
>> ---
>> v5 -> v6
>>
>> - Fix a typo in version 5 of the patch for fixing TYPE and RETR
>> commands handling in FTP test server.
>> - Fix test for --https-only option by adding feature constraint on
>> HTTPS support.
>
> it seems fine for me. If Tim and Darshit also agree, I can push this
> series.
>
> Thanks again for your contribution.
>
> Giuseppe
Looks so much cleaner now! I haven't tested this code, but on a first
glance it looks fine to me too.
*Minor nuance*: "+@samp{--start-pos} has higher precedence over
@samp{--continue}. When": Single spacing at the end of a sentence.
Giuseppe could you kindly fix that while applying?
--
Thanking You,
Darshit Shah
