"Darshit Shah" <[email protected]> wrote:
progress bar to me. It does not change the existing output so we have
full backward compatibility with existing scripts, but allows the user
to explicitly display the progress bar if required.
I don't see your patch is considering the Windows console-title
progress indicator. In e.g. retr.c:
#ifdef WINDOWS
if (toread > 0 && !opt.quiet)
ws_percenttitle (100.0 *
(startpos + sum_read) / (startpos + toread));
#endif
Maybe this should test for this new option too? Something like:
if (toread > 0 && !opt.quiet || opt.show_progress)
...
But mswindows.c always needs a 'curr_url' to show percentage.
I don't think 'ws_changetitle()' will be called as needed for this to
happen. The best IMHO would be to drop 'ws_changetitle()' and
always have the current-URL as a parameter to 'ws_percenttitle()'.
--gv
