On Thu, Jul 17, 2014 at 1:15 PM, Tim Ruehsen <[email protected]> wrote: > On Wednesday 16 July 2014 23:37:20 Darshit Shah wrote: >> Hi Sagar, >> >> libpsl is a new package that is being developed by Tim Ruehsen. You >> can check out the development of libpsl on the link provided to you by >> Jure. >> >> If I remember correctly, libpsl has been packaged for and is available >> in debian unstable, and by extension in Ubuntu. If you're not on a >> debian derived system, you'll have to download and compile libpsl on >> your own. It's not too difficult though. > > It has been packaged, yes, but it is still in the Debian NEW queue waiting for > approval. > Aah! I was not aware of that. Anyways, we look forward to libpsl being packaged, so that it makes it easier for everyone to use it. >> In case, you don't want to use libpsl, you can simply configure wget >> with the --without-libpsl flag to disable libpsl support. > > Maybe Jure does not have the latest git version ? > If libpsl is not installed, HAVE_LIBPSL is not defined and in cookies.c you > correctly coded: > #ifdef HAVE_LIBPSL > # include <libpsl.h> > #endif > > To be *absolutely* correct, configure.ac should check for libpsl.h with > AC_CHECK_HEADERS(libpsl.h) and you should include libpsl.h like this > #ifdef HAVE_LIBPSL_H > #include <libpsl.h> > #endif > > But that is not the problem here, I think. > >> >> P.S - I'm working on the parallel-wget branch for the new Wget Test >> >> Suite. > > Arg, yes parallel-wget is missing something. > cookie.c includes libpsl.h without checking for HAVE_LIBPSL. > Yes. This was fixed in master after the merge into parallel-wget was completed.
> @Guiseppe: could you please merge the last change(s) from master ? Guiseppe, I guess we can safely merge master into parallel-wget for now. Could you please make the merge whenever possible? > > Tim > -- Thanking You, Darshit Shah
