More than reviewing, I was concerned if the way I've squashed the commits was fine.
Giuseppe's patches are fine. I've checked them before. I'll push the work into master asap. — Thanking you, Darshit Shah Sent from mobile. Please excuse any errors. On Thu, Jul 24, 2014 at 8:34 PM, Giuseppe Scrivano <[email protected]> wrote: > Darshit Shah <[email protected]> writes: >> The Python based test suite has been lying in parallel-wget for quite >> some time now. I proposed to merge that into origin/master recently. >> Attached are a set of patches that can be used to merge testenv/ the >> home of the Python based testsuite into master. >> >> In generating these patches, I've squashed consecutive commits from >> the same author into a single commit. > I've tested this series here and it seems to work fine here. >> >> Zinhang's patch on refactoring the test suite makes git complain about >> whitespace errors. However, you can safely ignore those since the >> errors are caused due to certain blank files that are required by >> Python for everything to work well. >> >> Do let me know if this series of patches seems sane and I'll push them >> to master. >> >> Darshit Shah (5): >> Introducing Python based Test Environment >> More features to Python based test suite >> Fix crash in test suite >> Document SERVER_WAIT >> Support running tests through valgrind > these were already reviewed, so I think there is no reason to review > them again. >> >> Zihang Chen (1): >> Refactor the Python based test suite > this too... >> Giuseppe Scrivano (2): >> testenv: fix make dist >> testenv: Remove Test--spider-r.py from XFAIL_TESTS > perhaps review just these two :-) if you are fine with them, just push > this series and you've got your last year Summer of Code project > completely into master right? So you can spend the weekend celebrating > this achievement! > Regards, > Giuseppe
