Darshit Shah <[email protected]> writes: > On Sat, Aug 23, 2014 at 9:57 PM, Giuseppe Scrivano <[email protected]> wrote: >> Darshit Shah <[email protected]> writes: >> >>> Hi Angel, >>> >>> I was wondering if the WGET variable should always contain the >>> absolute path to the executable. That way we do nopt rely on the $PATH >>> variable to detect wget. My suggestion would be to have the line >>> replaced as: >>> WGET=/usr/bin/wget >>> >>> So that the script always uses the wget executable and not any other >>> scripts called wget in $PATH >> >> I think it would be fine to assume that any "wget" in the PATH is >> actually the wget executable. Isn't that better than using an absolute >> path? :-) >> > > I guess so. Seems like the right way forward. In that case, maybe we > can push this patch?
yes, we should. Angel, how did you generate the patch? I am having some problems to apply it, "git am" gives me an error :-( Would you mind to send it trough git send-email or attach the "git format-patch" output? Thanks, Giuseppe
