Am Sonntag, 19. Oktober 2014, 17:41:30 schrieb Darshit Shah: > On 10/09, Tim Rühsen wrote: > >> Hence, hard coding the command actually reduces the amount of work a user > >> needs to do in order to run the tests under valgrind. > >> > >> My suggestion is that we allow the configure option, but hard code the > >> valgrind command into the test suites themselves, and not leave them > >> environment variables. > > > >What about removing the configure option and > >if VALGRIND_TESTS is undefined or empty or "0": normal testing > >if VALGRIND_TESTS is "1": valgrind testing with hard-coded options > >else: testing with command given in VALGRIND_TESTS > > > >The above described workflow should still work, right ? > >And we could do the complete test suite with > >VALGRIND_TESTS="1" make check > > > >What do you think ? > > --- end quoted text --- > > I actually like this idea. > case $VALGRIND_TESTS: > "", 0) Normal tests;; > 1) Hard coded valgrind string;; > *) Execute the provided command;; > > Could you please make the relevant changes to atleast the Perl based tests > and to configure.ac? I'm currently traveling, but I'll fix the Python tests > ASAP and send in a patch which will work well with the aforementioned > cases.
Hi Darshit, I care for that hopefully in the next days. I just building a new kitchen together with my wife. Thus I don't have much time to code/debug (right now she is out and fetches new building material, so I can read a few emails ;-) Tim
signature.asc
Description: This is a digitally signed message part.
