On Wednesday 05 November 2014 13:49:56 Darshit Shah wrote:
> * Off-topic:
> Looking at the condition, there's one comparison that we can avoid:
> hs->restval > 0
> contlen >= 0
> hs->restval >= contlen
> 
> In this case, hs->restval > 0 is redundant and un-needed.

ACK.

> I'm waiting for Giuseppe's views on this. Else, I'll split the condition
> into two parts, with the first one called CLOSE_FINISH instead of
> CLOSE_INVALIDATE

Splitting sounds reasonable to me.

Tim

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to