On 11/19, Ángel González wrote:
But URLs can be in non-ASCII characters. And similarly, if I remember correctly, the HTTP headers can contain data, especially about redirects and cookie information which is non-ASCII.On 18/11/14 12:53, Tim Ruehsen wrote:On Tuesday 18 November 2014 12:08:58 Giuseppe Scrivano wrote:There are many other places in Wget where we should use these functions. (See my email from 24.9.2014 13:08:21). I am not sure (in fact I doubt) that we can blindly replace strcasecmp and strncasecmp. So I try to make test cases to prove replacing is correct. What do you think ? I think the patch looks fine, and when other cases show up, we can replace the failing part with the c_ function from gnulib, as you said we can't blindly replace all occurrences.Actually, I think we can :)Excepting perhaps init.c, all .c files at src/ are in fact expecting a C-locale str(n)casecmp(they all deal with network protocols).
In such scenarios how does using the C Locale comparison work out? Unless that data is somehow first normalized to some ASCII compatible string.
Honestly, localization isn't something I know much about. But I'd like to know how this works.
Note 1: We have strcasecmp and strncasecmp functions in src/cmpt.c that could be removed.Note 2: As gnulib is providing them, the mswindows.h defining would be unnecessary.
--- end quoted text --- -- Thanking You, Darshit Shah
pgppXimISmior.pgp
Description: PGP signature
